:fix: add auto reconnect to service client #4012
Conversation
riccardomodanese
force-pushed
the
fix-service_client_auto_reconnect
branch
from
5ae4ffa to
f2243bc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4012 +/- ##
=============================================
- Coverage 16.87% 16.86% -0.01%
Complexity 10 10
=============================================
Files 1989 1987 -2
Lines 51791 51810 +19
Branches 4420 4421 +1
=============================================
Hits 8739 8739
- Misses 42648 42667 +19
Partials 404 404
|
commons/src/main/java/org/eclipse/kapua/commons/event/jms/JMSServiceEventBus.java
Show resolved
Hide resolved
client/security/src/main/java/org/eclipse/kapua/client/security/amqpclient/Client.java
Show resolved
Hide resolved
| consumer.setMessageListener(clientMessageListener); | ||
| producer = session.createProducer(session.createQueue(requestAddress)); | ||
| clientMessageListener.init(session, producer); | ||
| connectionStatus = true; |
There was a problem hiding this comment.
Is there not a way to read the connection status from one of these objects instead of managing it ourselves? Should it be set to false on exception?
There was a problem hiding this comment.
Unfortunately no. The javax.jms.Connection has no connect flag o isConnect method.
|
|
||
| private void disconnect() throws JMSException { | ||
| if (connection != null) { | ||
| connection.close(); |
There was a problem hiding this comment.
Shouldn't we set the connectionStatus here to false?
There was a problem hiding this comment.
I was relying on the ExceptionListener but you are right: it's better to set it here.
There was a problem hiding this comment.
Okay let's add it in, then I'd be okay approving this.
riccardomodanese
force-pushed
the
fix-service_client_auto_reconnect
branch
2 times, most recently
from
bb46a1d to
979de0d
Compare
riccardomodanese
force-pushed
the
fix-service_client_auto_reconnect
branch
from
979de0d to
dbe3bb8
Compare
Signed-off-by: riccardomodanese <[email protected]>
riccardomodanese
force-pushed
the
fix-service_client_auto_reconnect
branch
from
dbe3bb8 to
fc8ef49
Compare
Brief description of the PR.
Added a connection retry when the conection is dropped.
Related Issue
fixes 4011
Description of the solution adopted
Like for the service event connection a connection retry was added. This is triggered, through the connection event listener, when the connection is dropped.
Screenshots
none
Any side note on the changes made
none